linux-kernel - Re: [PATCH] mux: add SPDX identifiers to all mux source files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bff16a3b-92d8-9beb-78dd-d29a4f57f99e@axentia.se>
Date:   Fri, 8 Dec 2017 11:06:48 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mux: add SPDX identifiers to all mux source files

On 2017-12-08 10:43, Philipp Zabel wrote:
> Hi Peter,
> 
> On Thu, 2017-12-07 at 22:08 +0100, Peter Rosin wrote:
>> diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
>> index 37c1de359a70..935ac44aa209 100644
>> --- a/drivers/mux/mmio.c
>> +++ b/drivers/mux/mmio.c
>> @@ -1,11 +1,8 @@
>> +// SPDX-License-Identifier: GPL-2.0
> 
> Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

Thanks!

>> diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h
>> index ea96d4c82be7..5fc6bb2fefad 100644
>> --- a/include/linux/mux/consumer.h
>> +++ b/include/linux/mux/consumer.h
>> @@ -1,13 +1,10 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
> 
> Is there a system to the different comment styles in c the files vs in
> the headers?

Yes, headers are sometimes included by assemblers and other tools that
can't handle "new style" comments. I think. I'm just following the lead
set by others...

Cheers,
Peter