linux-kernel - Re: [PATCH v4 09/12] clk: qcom: Add Krait clock controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uHdFn_GxJuQ-HfQpGAM5rWOT7=DyKUGtDz6dadoxdkBcw@mail.gmail.com>
Date:   Fri, 8 Dec 2017 11:23:02 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Sricharan R <sricharan@...eaurora.org>,
        Stephen Boyd <sboyd@...eaurora.org>
Cc:     mturquette@...aro.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        viresh.kumar@...aro.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 09/12] clk: qcom: Add Krait clock controller driver

Sricharan, Stephen,

On Fri, Dec 8, 2017 at 10:29 AM, Sricharan R <sricharan@...eaurora.org> wrote:
> From: Stephen Boyd <sboyd@...eaurora.org>
>
> The Krait CPU clocks are made up of a primary mux and secondary
> mux for each CPU and the L2, controlled via cp15 accessors. For
> Kraits within KPSSv1 each secondary mux accepts a different aux
> source, but on KPSSv2 each secondary mux accepts the same aux
> source.
>
> Cc: <devicetree@...r.kernel.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
[]
> --- /dev/null
> +++ b/drivers/clk/qcom/krait-cc.c
> @@ -0,0 +1,350 @@
> +/* Copyright (c) 2013-2015, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Have you considered using the new SPDX ids? Something like this:

// SPDX-License-Identifier: GPL-2.0
// Copyright (c) 2013-2015, The Linux Foundation. All rights reserved.

Beside  being simpler and increasing the code to comment ratio by
deleting 9 lines of boilerplate, this will also save a few trees over
the long term each time that I print the source code of the kernel ;)
(do not worry, I am NOT as insane as to really print the kernel
sources, but someone more insane than me may well do it)

You may wonder about the C++ // comment style I used here... Please
see Linus posts on the topic as well as Thomas doc patches overall for
instructions on using the SPDX ids.

And if you were to do this for your past, present and future
contributions (eventually these of your group), I would be quite
grateful.

Thank you for your kind consideration

-- 
Cordially
Philippe Ombredanne