linux-kernel - Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171208103315.GF628@jagdpanzerIV>
Date:   Fri, 8 Dec 2017 19:33:15 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     "Liu, Changcheng" <changcheng.liu@...el.com>
Cc:     sergey.senozhatsky@...il.com, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org
Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

On (12/08/17 17:37), Liu, Changcheng wrote:
> 
> On some linux distributions, the default link of sh
> is dash which deoesn't support split array like
> ${var//,/ }
> It's better to force to use bash shell directly.
> 
> Signed-off-by: Liu Changcheng <changcheng.liu@...el.com>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>


	-ss

> diff --git a/tools/vm/slabinfo-gnuplot.sh b/tools/vm/slabinfo-gnuplot.sh
> index 35b0398..0cf28aa 100644
> --- a/tools/vm/slabinfo-gnuplot.sh
> +++ b/tools/vm/slabinfo-gnuplot.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>  
>  # Sergey Senozhatsky, 2015
>  # sergey.senozhatsky.work@...il.com
> -- 
> 2.7.4
>