linux-kernel - Re: [RFC][PATCH] staging: ion: Fix ion_cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLXC4gMHrTXAN_B+_5OxfZEdwv1cuMncrVXM22XhuPjgEw@mail.gmail.com>
Date:   Thu, 7 Dec 2017 17:21:37 -0800
From:   John Stultz <john.stultz@...aro.org>
To:     Laura Abbott <labbott@...hat.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Archit Taneja <architt@...eaurora.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Daniel Vetter <daniel@...ll.ch>,
        Dmitry Shmidt <dimitrysh@...gle.com>,
        Todd Kjos <tkjos@...gle.com>,
        Amit Pundir <amit.pundir@...aro.org>
Subject: Re: [RFC][PATCH] staging: ion: Fix ion_cma_heap allocations

On Thu, Dec 7, 2017 at 4:55 PM, Laura Abbott <labbott@...hat.com> wrote:
> On 12/07/2017 03:42 PM, John Stultz wrote:
>>
>> In trying to add support for drm_hwcomposer to HiKey,
>> I've needed to utilize the ION CMA heap, and I've noticed
>> problems with allocations on newer kernels failing.
>>
>> It seems back with 204f672255c22 ("ion: Use CMA APIs directly"),
>> the ion_cma_heap code was modified to use the CMA API, but
>> kept the arguments as buffer lengths rather then number of pages.
>>
>> This results in errors as we don't have enough pages in CMA to
>> satisfy the exaggerated requests.
>>
>> This patch converts the ion_cma_heap CMA API usage to properly
>> request pages.
>>
>> It also fixes a minor issue in the allocation where in the error
>> path, the cma_release is called with the buffer->size value which
>> hasn't yet been set.
>>
>> I'm no memory expert so close review would be appreciated!
>>
>
> Yup.
>
> Acked-by: Laura Abbott <labbott@...hat.com>

Thanks for that!

I realized right after sending that there's a checkpatch issue to be
fixed up, so I'll resend tomorrow (including your ack) if there aren't
any other objections.

thanks
-john