linux-kernel - Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171208113338.GA3134@aepfle.de>
Date:   Fri, 8 Dec 2017 12:33:38 +0100
From:   Olaf Hering <olaf@...fle.de>
To:     Eduardo Otubo <otubo@...hat.com>
Cc:     linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
        sthemmin@...rosoft.com, haiyangz@...rosoft.com, kys@...rosoft.com,
        vkuznets@...hat.com, mgamal@...hat.com, cavery@...hat.com
Subject: Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before
 setting ip

On Fri, Dec 08, Eduardo Otubo wrote:

>  tools/hv/hv_set_ifconfig.sh | 45 +++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 43 insertions(+), 2 deletions(-)

> +        # let's wait for 3 minutes

Was this codepath runtime tested?

Last time this came up, the conclusion was that Windows terminates the
"KVP connection" after 60 seconds. After that, the VM must be rebooted
because the kernel does not deal with the long-running script. It is
also not clear what the kernel is supposed to do: either silently report
success and hope the scripts reports success one day, or report error
independent from what the script actually returns. New KVP requests
would need to be queued either way.

Olaf

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)