linux-kernel - Re: [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87efo5h1yh.fsf@concordia.ellerman.id.au>
Date:   Fri, 08 Dec 2017 22:51:50 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Balbir Singh <bsingharora@...il.com>,
        Colin King <colin.king@...onical.com>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        "open list\:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" 
        <linuxppc-dev@...ts.ozlabs.org>, kernel-janitors@...r.kernel.org,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations

Balbir Singh <bsingharora@...il.com> writes:

> On Thu, Dec 7, 2017 at 10:01 PM, Colin King <colin.king@...onical.com> wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Use the ARRAY_SIZE macro on several arrays to determine their size.
>> Improvement suggested by coccinelle.
>
> This file is taken from binutils and re-licensed. Keeping the file
> as-is helps apply newer patches easily on top as opposed to redoing
> the changes. I would prefer not to move to ARRAY_SIZE and stick to
> what's already in the file.

Yep.

Thanks but no thanks on this one Colin.

Is there a checkpatch blacklist anywhere? So we don't keep discovering
things in this file that need to be fixed?

cheers