linux-kernel - [PATCH 0/6] staging: fsl-dpaa2/eth: Frame buffer optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171208124758.2732-1-ruxandra.radulescu@nxp.com>
Date:   Fri, 8 Dec 2017 06:47:52 -0600
From:   Ioana Radulescu <ruxandra.radulescu@....com>
To:     <gregkh@...uxfoundation.org>
CC:     <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        <bogdan.purcareata@....com>
Subject: [PATCH 0/6] staging: fsl-dpaa2/eth: Frame buffer optimizations

This patchset continues the work related to frame buffer layout.

The first two patches fix an issue and simplify some rather convoluted
formulas introduced by a previous commit.

The third adds a new counter for TX skb reallocations due to
insufficient headroom. This helped us notice that most of the frames
originated on the core had skbs with too little headroom, leading to
additional alloc/free operations and a performance penalty for
egress termination traffic.

A closer look at hardware requirements vs recommandations showed
that we don't in fact need to be so strict with our TX buffer layout.
The last three patches in this set remove all restrictions that are
not mandatory from a functional standpoint, lowering the required
TX headroom from 192B to 64B.

This helps avoid realloc's for most TCP frames. On a LS2088A board
with one core @2GHz, running a netperf TCP_SENDFILE test (as client),
we see an increase in throughput from 3.79Gbps to 5.11Gbps. For UDP
traffic no improvement is observed, since the stack usually creates
skbs with minimal headroom (2B) for UDP frames.

Ioana Radulescu (6):
  staging: fsl-dpaa2/eth: Fix access to FAS field
  staging: fsl-dpaa2/eth: Don't set netdev->needed_headroom
  staging: fsl-dpaa2/eth: Add counter for skb reallocs
  staging: fsl-dpaa2/eth: Don't enable FAS on Tx
  staging: fsl-dpaa2/eth: Compute needed headroom per frame
  staging: fsl-dpaa2/eth: Make Tx buffer alignment optional

 drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c     | 111 +++++----------------
 drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h     |  31 +++---
 drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c |   1 +
 3 files changed, 46 insertions(+), 97 deletions(-)

-- 
2.7.4