linux-kernel - Re: [PATCH RFC 3/7] KVM: timer: synchronize tsc-deadline timestamp for guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2017 10:06:19 -0500
From:   Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:     Quan Xu <quan.xu0@...il.com>
Cc:     pbonzini@...hat.com, rkrcmar@...hat.com, yang.zhang.wz@...il.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ben Luo <bn0418@...il.com>
Subject: Re: [PATCH RFC 3/7] KVM: timer: synchronize tsc-deadline timestamp
 for guest

On Fri, Dec 08, 2017 at 04:39:46PM +0800, Quan Xu wrote:
> From: Ben Luo <bn0418@...il.com>
> 
> In general, KVM guest programs tsc-deadline timestamp to
> MSR_IA32_TSC_DEADLINE MSR. This will cause a VM-exit, and
> then KVM handles this timer for guest.
> 
> The tsc-deadline timestamp is mostly recorded in share page
> with less VM-exit. We Introduce a periodically working kthread
> to scan share page and synchronize timer setting for guest
> on a dedicated CPU.

That sounds like a race. Meaning the guest may put too small window
and this 'working thread to scan' may not get to it fast enough?

Meaning we miss the deadline to inject the timer in the guest.

Or is this part of this PV MSR semantics - that it will only work
for certain amount of values and anything less than say 1ms
should not use the PV MSR?