linux-kernel - Re: [PATCH v1 1/2] eeprom: at24: convert magic numbers to structs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiXpwcjndtFhtCFhESagN9CRWiS0jFdndiNE2oupBQdDSw@mail.gmail.com>
Date:   Fri, 8 Dec 2017 10:28:27 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Sven Van Asbroeck <svendev@...x.com>,
        Wolfram Sang <wsa@...-dreams.de>, nsekhar@...com,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Javier Martinez Canillas <javier@...hile0.org>,
        Divagar Mohandass <divagar.mohandass@...el.com>,
        devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v1 1/2] eeprom: at24: convert magic numbers to structs.

Bartosz wrote:
> Just make it accept two parameters: the string and the data object
> name. For example:
>
> AT24_OF_DEVICE_ID("atmel,24c01", 24c01);
>

I don't want to do too much bikeshedding,
but one last comment.

Is it a good idea to have duplicated information?
Do you think the risk of a typo mismatch is acceptable? E.g.
AT24_OF_DEVICE_ID("atmel,24c01", 24c02);

At least the original syntax is not susceptible to this problem,
but of course as you say, it hides the of_ compatible string:
AT24_OF_DEVICE_ID(atmel, 24c01);
/* hides 'atmel,24c01' */

Pros and cons. Pick one.