linux-kernel - Re: [PATCH] ACPICA: Fix indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2017 18:06:19 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     Robert Moore <robert.moore@...el.com>, Lv <lv.zheng@...el.com>,
        Rafael Wysocki <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Schmauss, Erik" <erik.schmauss@...el.com>
Subject: Re: [PATCH] ACPICA: Fix indentation

On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@...il.com> wrote:
> This patch avoids that smatch reports the following:
> drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn: inconsistent indenting
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>

This is ACPICA code, so changes like this should go in via the upstream.

Erik may want to pick this up, however.

> ---
>  drivers/acpi/acpica/exdump.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
> index 83398dc..f43d3d7 100644
> --- a/drivers/acpi/acpica/exdump.c
> +++ b/drivers/acpi/acpica/exdump.c
> @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union acpi_operand_object *obj_desc, u32 depth)
>
>         ACPI_FUNCTION_NAME(ex_dump_operand)
>
> -           /* Check if debug output enabled */
> -           if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> +       /* Check if debug output enabled */
> +       if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
>                 return;
>         }
>
> --