linux-kernel - Re: [PATCH v1 1/6] ARM: davinci: clean up map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2017 13:11:03 -0600
From:   David Lechner <david@...hnology.com>
To:     Sekhar Nori <nsekhar@...com>, linux-arm-kernel@...ts.infradead.org
Cc:     Kevin Hilman <khilman@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/6] ARM: davinci: clean up map_io functions

On 12/08/2017 09:38 AM, Sekhar Nori wrote:
> On Saturday 02 December 2017 08:04 AM, David Lechner wrote:
>>   static int dm355leopard_mmc_get_cd(int module)
>>   {
>>   	if (!gpio_is_valid(leopard_mmc_gpio))
>> @@ -269,7 +264,7 @@ static __init void dm355_leopard_init(void)
>>   
>>   MACHINE_START(DM355_LEOPARD, "DaVinci DM355 leopard")
>>   	.atag_offset  = 0x100,
>> -	.map_io	      = dm355_leopard_map_io,
>> +	.map_io		= dm355_map_io,
>>   	.init_irq     = davinci_irq_init,
>>   	.init_time	= davinci_timer_init,
>>   	.init_machine = dm355_leopard_init,
> 
> It seems like spaces were used in original code for indentation. Can you
> please introduce a patch to fix that first since you are now touching
> this part of the code?

Many of the board files have mixed spaces and tabs here. I went with 
tabs since the newest commits used tabs. But, yes, I can clean this up.