linux-kernel - Re: [GIT PULL for v4.15-rc3] media fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2017 13:28:57 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL for v4.15-rc3] media fixes

On Fri, Dec 8, 2017 at 7:56 AM, Mauro Carvalho Chehab
<mchehab@....samsung.com> wrote:
>
> - The largest amount of fixes in this series is with regards to comments
>   that aren't kernel-doc, but start with "/**". A new check added for
>   4.15 makes it to produce a *huge* amount of new warnings (I'm compiling
>   here with W=1). Most of the patches in this series fix those. No code
>   changes - just comment changes at the source files;

Guys, this was just pure garbage, and obviously noboduy actually
looked at that shit-for-brains patch.

There were several idiotic things like this:

  -/******************************
  +/*****************************

because part of it was apparently generated with some overly stupid
search-and-replace. So when replacing "/**" with "/*", it also just
removed a star from those boxed-in comments.

In the process that thing also made some of those boxes no longer aligned.

Now, box comments are stupid anyway, but they become truly
mind-bogglingly pointless when they are then edited like this.

I've pulled this, but dammit, show some amount of sense. We shouldn't
have this kind of pointless noise in the rc series. That pointless
noise may now be hiding the real changes.

              Linus