lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJZ5v0gNgOEmKE_Sf1Hfwmw=PDQ4QGe4UvWhr0=wNUrS6fnS2g@mail.gmail.com> Date: Sat, 9 Dec 2017 15:13:49 +0100 From: "Rafael J. Wysocki" <rafael@...nel.org> To: Bjorn Helgaas <helgaas@...nel.org> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM <linux-pm@...r.kernel.org>, Linux PCI <linux-pci@...r.kernel.org>, Linux ACPI <linux-acpi@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ulf Hansson <ulf.hansson@...aro.org>, Mika Westerberg <mika.westerberg@...ux.intel.com> Subject: Re: [PATCH] PM / sleep: Avoid excess pm_runtime_enable() calls in device_resume() On Fri, Dec 8, 2017 at 9:25 PM, Bjorn Helgaas <helgaas@...nel.org> wrote: > On Thu, Dec 07, 2017 at 03:26:14AM +0100, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com> >> >> Middle-layer code doing suspend-time optimizations for devices with >> the DPM_FLAG_SMART_SUSPEND flag set (currently, the PCI bus type and >> the ACPI PM domain) needs to make the core skip ->thaw_early and >> ->thaw callbacks for those devices in some cases and it sets the >> power.direct_complete flag for them for this purpose. >> >> However, it turns out that setting power.direct_complete outside of >> the PM core is a bad idea as it triggers an excessive invocation of >> pm_runtime_enable() in device_resume(). >> >> For this reason, provide a helper to clear power.is_late_suspended >> and power.is_suspended to be invoked by the middle-layer code in >> question instead of setting power.direct_complete and make that code >> call the new helper. >> >> Fixes: c4b65157aeef (PCI / PM: Take SMART_SUSPEND driver flag into account) >> Fixes: 05087360fd7a (ACPI / PM: Take SMART_SUSPEND driver flag into account) >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> > > Acked-by: Bjorn Helgaas <bhelgaas@...gle.com> > > I don't pretend to understand this (and I don't need to, so don't > waste your time explaining), but I trust you :) Thank you! :-)
Powered by blists - more mailing lists