linux-kernel - [PATCH] lib/usercopy: fix sparse errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171209162424.E5CEF41C4C@localhost.localdomain>
Date:   Sat,  9 Dec 2017 17:24:24 +0100 (CET)
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] lib/usercopy: fix sparse errors

  CHECK   lib/usercopy.c
lib/usercopy.c:26:13: warning: incorrect type in argument 1 (different address spaces)
lib/usercopy.c:26:13:    expected void const volatile [noderef] <asn:1>*<noident>
lib/usercopy.c:26:13:    got void *to
lib/usercopy.c:27:34: warning: incorrect type in argument 1 (different address spaces)
lib/usercopy.c:27:34:    expected void const volatile *p
lib/usercopy.c:27:34:    got void const [noderef] <asn:1>*from
lib/usercopy.c:28:38: warning: incorrect type in argument 1 (different address spaces)
lib/usercopy.c:28:38:    expected void [noderef] <asn:1>*to
lib/usercopy.c:28:38:    got void *to
lib/usercopy.c:28:42: warning: incorrect type in argument 2 (different address spaces)
lib/usercopy.c:28:42:    expected void const *from
lib/usercopy.c:28:42:    got void const [noderef] <asn:1>*from
lib/usercopy.c:23:15: error: symbol '_copy_to_user' redeclared with different type (originally declared at ./include/linux/uaccess.h:140) - incompatible argument 1 (different address spaces)
  CC      lib/usercopy.o

Fixes: d597580d37377 ("generic ...copy_..._user primitives")
Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
---
 lib/usercopy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/usercopy.c b/lib/usercopy.c
index 15e2e6f..3744b2a 100644
--- a/lib/usercopy.c
+++ b/lib/usercopy.c
@@ -20,7 +20,7 @@ EXPORT_SYMBOL(_copy_from_user);
 #endif
 
 #ifndef INLINE_COPY_TO_USER
-unsigned long _copy_to_user(void *to, const void __user *from, unsigned long n)
+unsigned long _copy_to_user(void __user *to, const void *from, unsigned long n)
 {
 	might_fault();
 	if (likely(access_ok(VERIFY_WRITE, to, n))) {
-- 
2.2.2


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus