linux-kernel - Re: [PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG around dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 09 Dec 2017 10:08:29 -0800
From:   Joe Perches <joe@...ches.com>
To:     Simon Sandström <simon@...anor.nu>,
        gregkh@...uxfoundation.org
Cc:     marcin.s.ciupak@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG
 around dev_dbg

On Sat, 2017-12-09 at 19:02 +0100, Simon Sandström wrote:
> dev_dbg() already depends on DEBUG.

Not quite.

It depends on CONFIG_DYNAMIC_DEBUG or DEBUG

In any case, this patch is fine.

> Signed-off-by: Simon Sandström <simon@...anor.nu>
> ---
>  drivers/staging/pi433/rf69.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 04a74423c325..6e38e6a515a4 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -767,9 +767,7 @@ int rf69_read_fifo (struct spi_device *spi, u8 *buffer, unsigned int size)
>  	int retval;
>  
>  	if (size > FIFO_SIZE) {
> -#ifdef DEBUG
>  		dev_dbg(&spi->dev, "read fifo: passed in buffer bigger then internal buffer\n");
> -#endif
>  		return -EMSGSIZE;
>  	}
>  
> @@ -801,9 +799,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size)
>  	u8 local_buffer[FIFO_SIZE + 1];
>  
>  	if (size > FIFO_SIZE) {
> -#ifdef DEBUG
>  		dev_dbg(&spi->dev, "read fifo: passed in buffer bigger then internal buffer\n");
> -#endif
>  		return -EMSGSIZE;
>  	}
>