linux-kernel - [PATCH 2/3] serial: ifx6x60: Improve a size determination in ifx_spi_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2134a9fd-73d9-686f-cc41-0d143a62cbbe@users.sourceforge.net>
Date:   Sat, 9 Dec 2017 20:12:21 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH 2/3] serial: ifx6x60: Improve a size determination in
 ifx_spi_spi_probe()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 9 Dec 2017 19:22:50 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/tty/serial/ifx6x60.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 832751479f41..1883e3382338 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -1005,7 +1005,7 @@ static int ifx_spi_spi_probe(struct spi_device *spi)
 	}
 
 	/* initialize structure to hold our device variables */
-	ifx_dev = kzalloc(sizeof(struct ifx_spi_device), GFP_KERNEL);
+	ifx_dev = kzalloc(sizeof(*ifx_dev), GFP_KERNEL);
 	if (!ifx_dev)
 		return -ENOMEM;
 
-- 
2.15.1