linux-kernel - Re: [PATCH 4/4] checkpatch: add check for tag Co-Developed-by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171209011845.GA2191@eros>
Date:   Sat, 9 Dec 2017 12:18:45 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH 4/4] checkpatch: add check for tag Co-Developed-by

On Fri, Dec 08, 2017 at 08:42:52AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 08, 2017 at 10:27:51AM +1100, Tobin C. Harding wrote:
> > From: Joe Perches <joe@...ches.com>
> > 
> > Recently signature tag Co-Developed-by was added to the
> > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know
> > about it yet. All prior tags used all lowercase characters except for first
> > character. Checks for this format had to be re-worked to allow for the
> > new tag.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Tobin C. Harding <me@...in.cc>
> > ---
> > 
> > Greg,
> > 
> > This patch has the same brief commit and achieves the same aim as the
> > code you reviewed. I'm adding your tag here even though the code is
> > totally different. I believe you were reviewing the behaviour of the
> > code not the actual logic.
> 
> Well, I did read the actual logic, I do know perl :)

No offense meant, just trying to make your day easier.

> Anyway, my reviewed-by still stands here, thanks.

thanks,
Tobin.