linux-kernel - Re: [PATCH 4.4 89/96] spi: SPI_FSL_DSPI should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171209054027.3owzecil4tvcgola@sasha-lappy>
Date:   Sat, 9 Dec 2017 05:40:28 +0000
From:   alexander.levin@...izon.com
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 4.4 89/96] spi: SPI_FSL_DSPI should depend on HAS_DMA

On Thu, Dec 07, 2017 at 08:41:14PM +0000, Ben Hutchings wrote:
>On Tue, 2017-11-28 at 11:23 +0100, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Geert Uytterhoeven <geert@...ux-m68k.org>
>>
>>
>> [ Upstream commit dadab2d4e3cf708ceba22ecddd94aedfecb39199 ]
>>
>> If NO_DMA=y:
>>
>>     ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!
>>
>> Add a dependency on HAS_DMA to fix this.
>[...]
>
>This driver did not use DMA before 4.10, so I think this should be
>reverted in the 4.4 and 4.9 branches.

I'll revert it for 4.4 and 4.9, thanks Ben!

-- 

Thanks,
Sasha