linux-kernel - Re: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for libusbip development

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171209061602.lvnxuqvnlihoz6wc@sasha-lappy>
Date:   Sat, 9 Dec 2017 06:16:04 +0000
From:   alexander.levin@...izon.com
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Ben Hutchings <ben@...adent.org.uk>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for
 libusbip development

On Fri, Dec 08, 2017 at 03:56:40AM +0000, Ben Hutchings wrote:
>On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Ben Hutchings <ben@...adent.org.uk>
>>
>>
>> [ Upstream commit c15562c0dcb2c7f26e891923b784cf1926b8c833 ]
>>
>> usbip_host_driver.h now depends on several additional headers, which
>> need to be installed along with it.
>>
>> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver ...")
>> Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with ...")
>> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
>> Acked-by: Shuah Khan <shuahkh@....samsung.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> ---
>>  tools/usb/usbip/Makefile.am |    3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> --- a/tools/usb/usbip/Makefile.am
>> +++ b/tools/usb/usbip/Makefile.am
>> @@ -1,6 +1,7 @@
>>  SUBDIRS := libsrc src
>>  includedir = @includedir@...bip
>>  include_HEADERS := $(addprefix libsrc/, \
>> -		     usbip_common.h vhci_driver.h usbip_host_driver.h)
>> +		     usbip_common.h vhci_driver.h usbip_host_driver.h \
>> +		     list.h sysfs_utils.h usbip_host_common.h)
>
>usbip_host_common.h was added in 4.7 (by the second commit listed
>above), so for 4.4 and 3.18 it should not be added to this list.

Thanks Ben!

Greg, I'm not sure how to send you fixes for patches currently in your
-rc cycle, since ideally you would just remove them instead of
reverting. Any ideas?

-- 

Thanks,
Sasha