linux-kernel - Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99b7f8b6-d6b5-b9cc-278c-19ffcad98081@lwfinger.net>
Date:   Sat, 9 Dec 2017 20:27:09 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Neil Singh <neil2468@...il.com>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org
Subject: Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue
 WARNING:LONG_LINE

On 12/09/2017 05:11 AM, Neil Singh wrote:
> Cleanup below checkpatch issue:
> 
> WARNING:LONG_LINE: line over 80 characters
> 1000: FILE: rtl871x_security.c:1000:
> +static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
> 
> Signed-off-by: Neil Singh <neil2468@...il.com>
> ---
>   drivers/staging/rtl8712/rtl871x_security.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
> index 56d36f6..77a5f5d 100644
> --- a/drivers/staging/rtl8712/rtl871x_security.c
> +++ b/drivers/staging/rtl8712/rtl871x_security.c
> @@ -997,7 +997,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists,
>   /* Builds the last MIC header block from        */
>   /* header fields.                               */
>   /************************************************/
> -static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
> +static void construct_ctr_preload(u8 *ctr_preload,
> +			   sint a4_exists, sint qc_exists,
>   			   u8 *mpdu, u8 *pn_vector, sint c)
>   {
>   	sint i;
> 

Did you run checkpatch on these patches? My system reports the following:

-------
patch_1
-------
WARNING: A patch subject line should describe the change not the tool that found it
#95:
Subject: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

CHECK: Alignment should match open parenthesis
#125: FILE: drivers/staging/rtl8712/rtl871x_security.c:1001:
+static void construct_ctr_preload(u8 *ctr_preload,
+                          sint a4_exists, sint qc_exists,

-------
patch_2
-------
WARNING: A patch subject line should describe the change not the tool that found it
#95:
Subject: [PATCH v2 2/2] staging: rtl8712: Cleanup checkpatch issues CODE_INDENT 
and LEADING_SPACE

Larry