linux-kernel - Re: [PATCH] eeprom: at24: code shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2017 09:08:48 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Heiner Kallweit <hkallweit1@...il.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeprom: at24: code shrink

Hello,

On Sun, Dec 10, 2017 at 08:29:47PM +0100, Bartosz Golaszewski wrote:
> @@ -625,7 +610,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  	at24->offset_adj = at24_get_offset_adj(chip.flags, chip.byte_len);
>  
>  	at24->client[0].client = client;
> -	at24->client[0].regmap = devm_regmap_init_i2c(client, config);
> +	at24->client[0].regmap = devm_regmap_init_i2c(client, &config);
>  	if (IS_ERR(at24->client[0].regmap))
>  		return PTR_ERR(at24->client[0].regmap);
>  

One side effect here that the lockdep name changes from (unhelpful)
"config" to (unhelpful and ugly) "&config". Probably doesn't matter much
...

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |