linux-kernel - [RESEND PATCH 2/2 v2] staging: fsl-mc: do not print error in case of defer probe error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2017 21:15:38 +0530
From:   Nipun Gupta <nipun.gupta@....com>
To:     <laurentiu.tudor@....com>, <stuyoder@...il.com>,
        <bharat.bhushan@....com>, <gregkh@...uxfoundation.org>,
        <cakturk@...il.com>, <bretth256@...il.com>, <arnd@...db.de>
CC:     <linux-kernel@...r.kernel.org>, <devel@...verdev.osuosl.org>,
        Nipun Gupta <nipun.gupta@....com>
Subject: [RESEND PATCH 2/2 v2] staging: fsl-mc: do not print error in case of defer probe error

Devices on MC bus can be deferred because of dependencies on other modules
(such as IOMMU). Those are not the actual errors; as probing is again
done by the kernel at later stages. So this patch avoids the error print
in such case.

Signed-off-by: Nipun Gupta <nipun.gupta@....com>
---
Resending v2 as missed mentioning the changes in the version
Changes in v2:
  - Added commit message

 drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
index 409f2b9..10cee00 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
@@ -171,7 +171,8 @@ static int fsl_mc_driver_probe(struct device *dev)
 
 	error = mc_drv->probe(mc_dev);
 	if (error < 0) {
-		dev_err(dev, "%s failed: %d\n", __func__, error);
+		if (error != -EPROBE_DEFER)
+			dev_err(dev, "%s failed: %d\n", __func__, error);
 		return error;
 	}
 
-- 
1.9.1