linux-kernel - Re: [PATCH] checkpatch: don't require octal permissions for "0"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512958743.26342.32.camel@perches.com>
Date:   Sun, 10 Dec 2017 18:19:03 -0800
From:   Joe Perches <joe@...ches.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Whitcroft <apw@...onical.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: don't require octal permissions for "0"

On Sun, 2017-12-10 at 15:04 +0100, Bartosz Golaszewski wrote:
> If the permission value is 0, don't raise the NON_OCTAL_PERMISSIONS
> error. There's no possibility of an error if there are no permissions.
> 
> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6b130a4116fa..ea98e298d3ac 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6321,7 +6321,7 @@ sub process {
>  				if ($stat =~ /$test/) {
>  					my $val = $1;
>  					$val = $6 if ($skip_args ne "");
> -					if (($val =~ /^$Int$/ && $val !~ /^$Octal$/) ||
> +					if (($val ne "0" && $val =~ /^$Int$/ && $val !~ /^$Octal$/) ||
>  					    ($val =~ /^$Octal$/ && length($val) ne 4)) {
>  						ERROR("NON_OCTAL_PERMISSIONS",
>  						      "Use 4 digit octal (0777) not decimal permissions\n" . "$here\n" . $stat_real);

perhaps
---
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6b130a4116fa..950bbc0e6e3f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6321,7 +6321,8 @@ sub process {
 				if ($stat =~ /$test/) {
 					my $val = $1;
 					$val = $6 if ($skip_args ne "");
-					if (($val =~ /^$Int$/ && $val !~ /^$Octal$/) ||
+					if ($func !~ /^module_param/ &&
+					    ($val =~ /^$Int$/ && $val !~ /^$Octal$/) ||
 					    ($val =~ /^$Octal$/ && length($val) ne 4)) {
 						ERROR("NON_OCTAL_PERMISSIONS",
 						      "Use 4 digit octal (0777) not decimal permissions\n" . "$here\n" . $stat_real);