linux-kernel - [PATCH] DMA:omap-dma: Fix kernel compilation error and checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1513000833-17514-1-git-send-email-venkat.prashanth2498@gmail.com>
Date:   Mon, 11 Dec 2017 19:30:33 +0530
From:   venkat.prashanth2498@...il.com
To:     vinod.koul@...el.com, dan.j.williams@...el.com
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Venkat Prashanth B U <venkat.prashanth2498@...il.com>
Subject: [PATCH] DMA:omap-dma: Fix kernel compilation error and checkpatch issues

From: Venkat Prashanth B U <venkat.prashanth2498@...il.com>

This is the patch to the omap-dma.c file that fixes
the following issues:

1.redefinition of 'omap_dma_filter_fn' in the line 1273
of drivers/dma/omap-dma.c

2.drivers/dma/omap-dma.c:341: ERROR: code indent should
use tabs where possible reported by ./checkpatch.pl

3.drivers/dma/omap-dma.c:749: WARNING: Missing a blank
line after declarations reported by ./checkpatch.pl

Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@...il.com>
---
 drivers/dma/omap-dma.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index 1dfc71c..2a40485 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -338,7 +338,7 @@ static void omap_dma_stop(struct omap_chan *c)
 		if (val & (CCR_RD_ACTIVE | CCR_WR_ACTIVE))
 			dev_err(c->vc.chan.device->dev,
 				"DMA drain did not complete on lch %d\n",
-			        c->dma_ch);
+				c->dma_ch);
 
 		omap_dma_glbl_write(od, OCP_SYSCONFIG, sysconfig);
 	} else {
@@ -746,6 +746,7 @@ static void omap_dma_issue_pending(struct dma_chan *chan)
 		 */
 		if (!c->cyclic) {
 			struct omap_dmadev *d = to_omap_dma_dev(chan->device);
+
 			spin_lock(&d->lock);
 			if (list_empty(&c->node))
 				list_add_tail(&c->node, &d->pending);
@@ -1269,7 +1270,7 @@ static struct platform_driver omap_dma_driver = {
 	},
 };
 
-bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
+bool omap_dma_filter_func(struct dma_chan *chan, void *param)
 {
 	if (chan->device->dev->driver == &omap_dma_driver.driver) {
 		struct omap_dmadev *od = to_omap_dma_dev(chan->device);
-- 
1.9.1