linux-kernel - Re: [PATCH 2/8] x86/early-quirks: replace the magical increment start values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2017 15:39:11 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Matthew Auld <matthew.auld@...el.com>
Cc:     intel-gfx@...ts.freedesktop.org,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Ville Syrjälä 
        <ville.syrjala@...ux.intel.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Paulo Zanoni <paulo.r.zanoni@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] x86/early-quirks: replace the magical increment
 start values


* Matthew Auld <matthew.auld@...el.com> wrote:

> Replace the magical +2, +9 etc. with +MB, which is far easier to read.
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@...el.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Cc: Chris Wilson <chris@...is-wilson.co.uk>
> Cc: Paulo Zanoni <paulo.r.zanoni@...el.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: linux-kernel@...r.kernel.org
> Reviewed-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> ---
>  arch/x86/kernel/early-quirks.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 6c1624889011..3cbb2c78a9df 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -428,9 +428,9 @@ static resource_size_t __init chv_stolen_size(int num, int slot, int func)
>  	if (gms < 0x11)
>  		return gms * MB(32);
>  	else if (gms < 0x17)
> -		return (gms - 0x11 + 2) * MB(4);
> +		return (gms - 0x11) * MB(4) + MB(8);
>  	else
> -		return (gms - 0x17 + 9) * MB(4);
> +		return (gms - 0x17) * MB(4) + MB(36);
>  }
>  
>  static resource_size_t __init gen9_stolen_size(int num, int slot, int func)
> @@ -446,7 +446,7 @@ static resource_size_t __init gen9_stolen_size(int num, int slot, int func)
>  	if (gms < 0xf0)
>  		return gms * MB(32);
>  	else
> -		return (gms - 0xf0 + 1) * MB(4);
> +		return (gms - 0xf0) * MB(4) + MB(4);

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo