linux-kernel - Re: [RESEND PATCH] irq_work: improve the flag definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hxHS_DkOeKBT7q8xF0yRf7=9MHjMCFtAyNxT0DbWxbv0g@mail.gmail.com>
Date:   Mon, 11 Dec 2017 15:52:11 +0100
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] irq_work: improve the flag definitions

2017-11-27 11:52 UTC+01:00, Bartosz Golaszewski <brgl@...ev.pl>:
> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY and change its name to
> IRQ_WORK_CLAIMED.
>
> While we're at it: use the BIT() macro for all flags.
>
> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>

Nice!

Acked-by: Frederic Weisbecker <frederic@...nel.org>