linux-kernel - Re: [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2017 17:59:29 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20

On 11.12.2017 13:12, Thierry Reding wrote:
> On Mon, Dec 11, 2017 at 02:19:43AM +0300, Dmitry Osipenko wrote:
>> HW reset isn't actually broken on Tegra20, but there is a dependency on
>> first display controller to be taken out of reset for the second to be
>> enabled successfully.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  drivers/gpu/drm/tegra/dc.c | 77 +++++++++++++++++++++++++++++-----------------
>>  drivers/gpu/drm/tegra/dc.h |  4 ++-
>>  2 files changed, 51 insertions(+), 30 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
>> index fc70351b9017..6139d3e9cedf 100644
>> --- a/drivers/gpu/drm/tegra/dc.c
>> +++ b/drivers/gpu/drm/tegra/dc.c
>> @@ -24,6 +24,8 @@
>>  #include <drm/drm_atomic_helper.h>
>>  #include <drm/drm_plane_helper.h>
>>  
>> +static struct tegra_dc *dc0;
> 
> I'd like to avoid the global variable. Perhaps you can use the
> driver_for_each_device() or driver_find_device() functions to find the
> correct device?

driver_find_device() fit perfectly, thank you for the suggestion.