linux-kernel - Re: [PATCH] usb: xhci: fix incorrect memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171211170149.GD9454@kroah.com>
Date:   Mon, 11 Dec 2017 18:01:49 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Lu Baolu <baolu.lu@...ux.intel.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: xhci: fix incorrect memset()

On Mon, Dec 11, 2017 at 02:59:13PM +0200, Mathias Nyman wrote:
> On 11.12.2017 13:27, Arnd Bergmann wrote:
> > gcc-8 warnings about the new driver using a memset with a bogus length:
> > 
> > drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit':
> > drivers/usb/host/xhci-dbgcap.c:369:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size]
> > 
> > It looks like the author meant to use sizeof() rather than ARRAY_SIZE()
> > here, so use that.
> > 
> > Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> 
> Another patch to fix the same thing was sent earlier as a follow up to the original series.
> https://marc.info/?l=linux-usb&m=151298133524873&w=2
> 
> But your patch includes the Fixes line with the commit id, which is nice.
> 
> Both fix the problem, It doesn't matter for me which one gets applied

They fix it in different ways, which is correct?

I'm guessing you tested yours?  And Arnd probably doesn't have the
hardware to do so?

thanks,

greg k-h