lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <3b22d1ed-fe8f-b733-1543-86e89b493114@arm.com> Date: Mon, 11 Dec 2017 18:29:59 +0000 From: Marc Zyngier <marc.zyngier@....com> To: Rasmus Villemoes <rasmus.villemoes@...vas.dk>, Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com> Cc: Alexander Stein <alexander.stein@...tec-electronic.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [RFC] irqchip: add support for LS1021A external interrupt lines On 11/12/17 09:30, Rasmus Villemoes wrote: > On 2017-12-08 17:02, Marc Zyngier wrote: [...] >> Overall, it is a bit annoying that you just copied the driver altogether >> instead of trying to allow the common stuff to be shared between >> drivers. Most of this is just boilerplate code... > > Yes, it did annoy me as well. However, the real meat of this is which > bits of which register to poke to support a negative polarity irq, and > there doesn't seem to be a good way to express that in DT. The register > offset and the mapping from external irq# to the GIC one is reasonably > easy (and would thus get rid of my NIRQ and INTPCR macros), but > describing the mapping from IRQ# to the bit that needs to be set (or > cleared) seems much harder. I cannot generalize from one example, so > lacking documentation for any other Layerscape SOC, whatever I might > come up with might not actually be useful for other hardware, making it > rather pointless. But if you have any suggestions for how the DT > bindings might look, I'm all ears. You could have a list of <bit irq> pairs defining the mapping, for example. But I'd encourage you to get in touch with the Freescale/NXP folks and find out how this HW works. get_maintainers.pl gives me this: Shawn Guo <shawnguo@...nel.org> Tang Yuantian <Yuantian.Tang@....com> Hou Zhiqiang <Zhiqiang.Hou@....com> Madalin Bucur <madalin.bucur@....com> Minghuan Lian <Minghuan.Lian@....com> Yuantian Tang <andy.tang@....com> Yangbo Lu <yangbo.lu@....com> "Horia Geantă" <horia.geanta@....com> I suggest you spam them and find out. Thanks, M. -- Jazz is not dead. It just smells funny...
Powered by blists - more mailing lists