linux-kernel - [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <57d96314-cc9c-0656-186e-4eb77a132b70@ettle.org.uk>
Date:   Mon, 11 Dec 2017 19:37:29 +0000
From:   James Ettle <james@...le.org.uk>
To:     linux-integrity@...r.kernel.org, azhar.shaikh@...el.com,
        jarkko.sakkinen@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, james.l.morris@...cle.com
Subject: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell
 system

Hello,

[First: Apologies if cross-posting from Kernel.org BZ is bad form; my distro BZ advised I post this to your mailing list as well.]

Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU breaks PS/2 keyboard and mouse. They just don't respond until after a suspend/resume cycle, and after that they later stop after a while.

I have confirmed this by blacklisting tpm modules. I noticed this first with kernel 4.13, and have bisected it down to:

5e572cab92f0bb56ca1e6e5ee4d807663a7ccbad is the first bad commit
commit 5e572cab92f0bb56ca1e6e5ee4d807663a7ccbad
Author: Azhar Shaikh <azhar.shaikh@...el.com>
Date:   Sun Jun 18 19:17:59 2017 -0700

    tpm: Enable CLKRUN protocol for Braswell systems
    
    To overcome a hardware limitation on Intel Braswell systems,
    disable CLKRUN protocol during TPM transactions and re-enable
    once the transaction is completed.
    
    Signed-off-by: Azhar Shaikh <azhar.shaikh@...el.com>
    Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
    Tested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
    Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
    Signed-off-by: James Morris <james.l.morris@...cle.com>

:040000 040000 5437c91886cb62c497255f2c60dbedd7268ab50d 1863a1738ded35a817aad52f9f2b451bd43623d7 M	drivers

Currently in Kernel.org bugzilla 197287.

Please let me know if you need any further info.

Many thanks,
James.