linux-kernel - [REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce skb_warn_bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a352e7b-0404-2f91-206f-099e2376ab9a@canonical.com>
Date:   Mon, 11 Dec 2017 15:35:34 -0500
From:   Joseph Salisbury <joseph.salisbury@...onical.com>
To:     edumazet@...gle.com
Cc:     dvyukov@...gle.com, willemb@...gle.com, davem@...emloft.net,
        daniel@...earbox.net, jakub.kicinski@...ronome.com,
        linux@...musvillemoes.dk, john.fastabend@...il.com, me@...in.cc,
        idosch@...lanox.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        stable@...r.kernel.org, 1715609@...s.launchpad.net
Subject: [REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce
 skb_warn_bad_offload() noise

Hi Eric,

A kernel bug report was opened against Ubuntu [0].  It was found that
reverting the following commit resolved this bug:

commit b2504a5dbef3305ef41988ad270b0e8ec289331c
Author: Eric Dumazet <edumazet@...gle.com>
Date:   Tue Jan 31 10:20:32 2017 -0800

    net: reduce skb_warn_bad_offload() noise

The regression was introduced as of v4.11-rc1 and still exists in
current mainline.

I was hoping to get your feedback, since you are the patch author.  Do
you think gathering any additional data will help diagnose this issue,
or would it be best to submit a revert request?

This commit did in fact resolve another bug[1], but in the process
introduced this regression.

Thanks,

Joe

[0] http://pad.lv/1715609
[1] http://pad.lv/1705447