linux-kernel - Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513035270.2747.31.camel@wdc.com>
Date:   Mon, 11 Dec 2017 23:34:31 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "nicolas.iooss_linux@....org" <nicolas.iooss_linux@....org>
CC:     "kartilak@...co.com" <kartilak@...co.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "satishkh@...co.com" <satishkh@...co.com>,
        "sebaddel@...co.com" <sebaddel@...co.com>
Subject: Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format

On Mon, 2017-12-11 at 23:54 +0100, Nicolas Iooss wrote:
> On Mon, Dec 11, 2017 at 11:22 PM, Bart Van Assche
> <Bart.VanAssche@....com> wrote:
> > On Sun, 2017-12-10 at 20:23 +0100, Nicolas Iooss wrote:
> > > -                       "hdr status = %s tag = 0x%x sc = 0x%p"
> > > +                       "hdr status = %s tag = 0x%x sc = 0x%p "
> > >                         "scsi_status = %x residual = %d\n",
> > 
> > Since the %p format specifier already inserts a 0x prefix, shouldn't 0x%p be changed
> > into %p?
> 
> Does it? On the kernel I use it does not, and the documentation for %p
> does not show a 0x prefix
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/printk-formats.txt?h=v4.15-rc3#n57).

Please ignore my comment.

Bart.