linux-kernel - Re: [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171212003126.GD27831@fury>
Date:   Mon, 11 Dec 2017 16:31:26 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Stefan Brüns <stefan.bruens@...h-aachen.de>
Cc:     platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        AceLan Kao <acelan.kao@...onical.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic

On Mon, Dec 11, 2017 at 02:48:23AM +0100, Stefan Brüns wrote:
> On Saturday, December 9, 2017 12:07:08 AM CET Darren Hart (VMware) wrote:
> > The new notify_handler logic determining if autorelease should be used or
> > not is a bit awkward, and can result in more than one call to
> > sparse_keymap_report_event for the same event (scancode). The nesting
> > and long lines also made it difficult to read.
> > 
> > Simplify the logic by eliminating a level of nesting with a goto and
> > always calculate autorelease and val so we can make a single call to
> > sparse_keymap_report_event.
> > 
> > Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> > Cc: Stefan Brüns <stefan.bruens@...h-aachen.de>
> > Cc: AceLan Kao <acelan.kao@...onical.com>
> > ---
> > Note: This is based on top of Stefan's v2 patch series for intel-vbtn,
> > currently in my review-dvhart branch.
> > 
> >  drivers/platform/x86/intel-vbtn.c | 25 +++++++++++++------------
> >  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> Reviewed-by: Stefan Brüns <stefan.bruens@...h-aachen.de>
> Tested-by: Stefan Brüns <stefan.bruens@...h-aachen.de>

Appreciate you taking the time to review and test, thank you!

-- 
Darren Hart
VMware Open Source Technology Center