linux-kernel - Re: [GIT PULL] SCSI fixes for 4.15-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyzrHj+rMN7Ct7xCEWZT=viXYAC1WZjfgFnM_R0tq1n5A@mail.gmail.com>
Date:   Tue, 12 Dec 2017 09:32:02 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     James Bottomley <James.Bottomley@...senpartnership.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] SCSI fixes for 4.15-rc3

On Tue, Dec 12, 2017 at 9:22 AM, Martin K. Petersen
<martin.petersen@...cle.com> wrote:
>
> Arnd and Johannes fixed this up right away:

The commit you point to _is_ the probnlem. It does:

    struct bfad_im_port_s *im_port = shost->hostdata[0];

which is utter bullshit crap.

Notice? It's assigning a pointer (im_port), from an integer value
("hostdata[0]" is "unsigned long").

The code is garbage.

                  Linus