linux-kernel - Re: [PATCH] ASOC: wm8960: Add multiple MCLK frequency support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171212173756.GM16323@sirena.org.uk>
Date:   Tue, 12 Dec 2017 17:37:56 +0000
From:   Mark Brown <broonie@...nel.org>
To:     "Chen.Liu" <chen.liu.opensource@...il.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        shengjiu.wang@...escale.com, patches@...nsource.wolfsonmicro.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASOC: wm8960: Add multiple MCLK frequency support

On Tue, Dec 12, 2017 at 07:58:56PM +0800, Chen.Liu wrote:

> +retry:
> +	if (unsupport) {

As Charles says this would be better as a loop.  It'd also be better to
say "unsupported" rather than "unsupport" - it scans better for native
speakers.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)