linux-kernel - Re: [PATCH] drivers/staging/irda: fix max dup length for kstrndup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171212102712.40e7a652@xeon-e3>
Date:   Tue, 12 Dec 2017 10:27:12 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Ma Shimiao <mashimiao.fnst@...fujitsu.com>
Cc:     <samuel@...tiz.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/staging/irda: fix max dup length for kstrndup

On Tue, 12 Dec 2017 16:54:44 +0800
Ma Shimiao <mashimiao.fnst@...fujitsu.com> wrote:

> If source string longer than max, kstrndup will alloc max+1 space.
> So, we should make sure the result will not over limit.
> 
> Signed-off-by: Ma Shimiao <mashimiao.fnst@...fujitsu.com>

Did you read the TODO file in drivers/staging/irda?
	
	The irda code will be removed soon from the kernel tree as it is old and
	obsolete and broken.

	Don't worry about fixing up anything here, it's not needed.