linux-kernel - Re: [PATCH] leds: as3645a: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7040653.C0Zv065OYX@avalon>
Date:   Wed, 13 Dec 2017 01:35:05 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Dan Murphy <dmurphy@...com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, rpurdie@...ys.net,
        jacek.anaszewski@...il.com, pavel@....cz, sakari.ailus@....fi,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings

Hi Dan,

Thank you for the patch.

On Tuesday, 12 December 2017 23:50:11 EET Dan Murphy wrote:
> Fix two checkpatch warnings for 80 char
> length and for a quoted string across multiple
> line warnings.
> 
> Signed-off-by: Dan Murphy <dmurphy@...com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/leds/leds-as3645a.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 9a257f969300..f883616d9e60 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct
> led_classdev_flash *fled, {
>  	struct as3645a *flash = fled_to_as3645a(fled);
> 
> -	flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
> +	flash->flash_current = as3645a_current_to_reg(flash, true,
> +						      brightness_ua);
> 
>  	return as3645a_set_current(flash);
>  }
> @@ -455,8 +456,8 @@ static int as3645a_detect(struct as3645a *flash)
> 
>  	/* Verify the chip model and version. */
>  	if (model != 0x01 || rfu != 0x00) {
> -		dev_err(dev, "AS3645A not detected "
> -			"(model %d rfu %d)\n", model, rfu);
> +		dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
> +			model, rfu);
>  		return -ENODEV;
>  	}


-- 
Regards,

Laurent Pinchart