linux-kernel - Re: [PATCH v3 2/2] clocksource: sprd: Add timer driver for Spreadtrum SC9860 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1deccee-66d6-632f-9153-fb4b3c6bf60f@linaro.org>
Date:   Tue, 12 Dec 2017 10:43:40 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     Baolin Wang <baolin.wang@...eadtrum.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        DTML <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Chunyan Zhang <zhang.chunyan@...aro.org>
Subject: Re: [PATCH v3 2/2] clocksource: sprd: Add timer driver for Spreadtrum
 SC9860 platform

On 12/12/2017 10:41, Baolin Wang wrote:
> Hi Daniel,
> 
> On 12 December 2017 at 17:26, Baolin Wang <baolin.wang@...aro.org> wrote:
>> Hi Daniel,
>>
>> On 12 December 2017 at 17:16, Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
>>>
>>> Hi Baolin,
>>>
>>>
>>> On 08/12/2017 09:20, Baolin Wang wrote:
>>>
>>> [ ... ]
>>>
>>>>>> +static irqreturn_t sprd_timer_interrupt(int irq, void *dev_id)
>>>>>> +{
>>>>>> +     struct clock_event_device *ce = (struct clock_event_device *)dev_id;
>>>>>> +     struct timer_of *to = to_timer_of(ce);
>>>>>> +
>>>>>> +     sprd_timer_clear_interrupt(timer_of_base(to));
>>>>>> +
>>>>>> +     if (clockevent_state_oneshot(ce))
>>>>>> +             sprd_timer_disable(timer_of_base(to));
>>>>>> +
>>>>>> +     ce->event_handler(ce);
>>>>>> +     return IRQ_HANDLED;
>>>>>> +}
>>>>>> +
>>>>>> +static struct timer_of to = {
>>>>>> +     .flags = TIMER_OF_IRQ | TIMER_OF_BASE,
>>>>>
>>>>> Why not the TIMER_OF_CLOCK ?
>>>>
>>>> The timer's clock is fixed to 32.768K and no need to divide the
>>>> frequency, so our clock tree does not supply the timer's clock now.
>>>
>>> The driver is fine. However, I would like to unify the clk usage in the
>>> timer driver, so if you refer to a clock so the TIMER_OF_CLOCK can be
>>> used, that will nice.
>>
>> I understand your concern, but I've asked our clock driver owner in
>> Spreadtrum, we have no related registers to describe the topology of
>> the RTC fixed 32.768K, so the clock driver can not add timer's clock
>> node.
> 
> Sorry for my misunderstanding, I confirmed with Chunyan (who
> upstreamed our clock driver), she told me that we can get the clock
> rate from clock node. I will fix this issue in next version. Thanks
> for your comments.

Great, thanks Baolin.


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog