linux-kernel - [tip:x86/boot] x86/xen: Fix the boot loader version reported for PVH guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-88750a6c33f813b815516990f01fb5ee488c477e@git.kernel.org>
Date:   Tue, 12 Dec 2017 02:54:39 -0800
From:   tip-bot for Juergen Gross <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, peterz@...radead.org, jgross@...e.com,
        mingo@...nel.org, hpa@...or.com
Subject: [tip:x86/boot] x86/xen: Fix the boot loader version reported for
 PVH guests

Commit-ID:  88750a6c33f813b815516990f01fb5ee488c477e
Gitweb:     https://git.kernel.org/tip/88750a6c33f813b815516990f01fb5ee488c477e
Author:     Juergen Gross <jgross@...e.com>
AuthorDate: Fri, 8 Dec 2017 16:11:38 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Mon, 11 Dec 2017 15:14:20 +0100

x86/xen: Fix the boot loader version reported for PVH guests

The boot loader version reported via sysfs is wrong in case of the
kernel being booted via the Xen PVH boot entry. it should be 2.12
(0x020c), but it is reported to be 2.18 (0x0212).

As the current way to set the version is error prone use the more
readable variant (2 << 8) | 12.

Signed-off-by: Juergen Gross <jgross@...e.com>
Cc: <stable@...r.kernel.org> # 4.12
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: boris.ostrovsky@...cle.com
Cc: corbet@....net
Cc: lenb@...nel.org
Cc: linux-acpi@...r.kernel.org
Cc: rjw@...ysocki.net
Cc: xen-devel@...ts.xenproject.org
Link: http://lkml.kernel.org/r/20171208151139.30213-4-jgross@suse.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/xen/enlighten_pvh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c
index 436c4f0..6e6430c 100644
--- a/arch/x86/xen/enlighten_pvh.c
+++ b/arch/x86/xen/enlighten_pvh.c
@@ -69,7 +69,7 @@ static void __init init_pvh_bootparams(void)
 	 * Version 2.12 supports Xen entry point but we will use default x86/PC
 	 * environment (i.e. hardware_subarch 0).
 	 */
-	pvh_bootparams.hdr.version = 0x212;
+	pvh_bootparams.hdr.version = (2 << 8) | 12;
 	pvh_bootparams.hdr.type_of_loader = (9 << 4) | 0; /* Xen loader */
 }