linux-kernel - [BUG] drivers/scsi/dpt_i2o: a possible sleep-in-atomic bug in adpt_i2o_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 10:11:30 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     aacraid@...ptec.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [BUG] drivers/scsi/dpt_i2o: a possible sleep-in-atomic bug in
 adpt_i2o_post_this

According to drivers/scsi/dpt_i2o.c, the kernel module may sleep under a 
spinlock.
The function call paths are:
adpt_abort (acquire the spinlock)
   adpt_i2o_post_wait
     adpt_i2o_post_this
       schedule_timeout_uninterruptible--> may sleep

adpt_device_reset (acquire the spinlock)
   adpt_i2o_post_wait
     adpt_i2o_post_this
       schedule_timeout_uninterruptible--> may sleep

adpt_bus_reset (acquire the spinlock)
   adpt_i2o_post_wait
     adpt_i2o_post_this
       schedule_timeout_uninterruptible--> may sleep

A possible fixing is to replace "schedule_timeout_uninterruptible" with 
"mdelay".
If this fixing is correct, I can send a patch.
This possible bug is found by my static analysis tool (DSAC) and checked 
by my code review.


Thanks,
Jia-Ju Bai