[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 12 Dec 2017 13:04:01 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Steven Eckhoff <steven.eckhoff.opensource@...il.com>
CC: <alsa-devel@...a-project.org>, Liam Girdwood <lgirdwood@...il.com>,
"Mark Brown" <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's
TSCS42xx audio CODEC
On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> Currently there is no support for the TSCS42xx audio CODEC.
>
> Add support for it.
>
> v5 attempts to address all issues raised in the previous reviews.
>
> Thank you to everyone who has invested their time reviewing these
> patches.
>
> Acked-by: Philippe Ombredanne <pombredanne@...b.com>
> Signed-off-by: Steven Eckhoff <steven.eckhoff.opensource@...il.com>
> ---
> +int bytes_tlv_callback(struct snd_kcontrol *kcontrol, int op_flag,
> + unsigned int size, unsigned int __user *tlv)
> +{
> + struct tscs_dsp_ctl *ctl =
> + (struct tscs_dsp_ctl *)kcontrol->private_value;
> + struct soc_bytes_ext *params = &ctl->bytes_ext;
> + unsigned int count = size < params->max ? size : params->max;
> + int ret = -ENXIO;
> +
> + switch (op_flag) {
> + case SNDRV_CTL_TLV_OP_READ:
> + if (params->get)
> + ret = params->get(kcontrol, tlv, count);
> + break;
> + case SNDRV_CTL_TLV_OP_WRITE:
> + if (params->put)
> + ret = params->put(kcontrol, tlv, count);
> + break;
> + }
> + return ret;
> +}
Should this function be removed, I am assuming it is a hang over
from the earlier TLV implementation?
Thanks,
Charles
Powered by blists - more mailing lists