linux-kernel - Re: [PATCH v2] misc: mic: Use memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHYXAnJw78JRqBj9LBr5-e0PffO=xXeRDJvs9cHCYjR0Wcw3tg@mail.gmail.com>
Date:   Tue, 12 Dec 2017 14:22:41 +0100
From:   "Gomonovych, Vasyl" <gomonovych@...il.com>
To:     Greg KH <greg@...ah.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Arnd Bergmann <arnd@...db.de>, sudeep.dutt@...el.com,
        ashutosh.dixit@...el.com, dan.carpenter@...cle.com,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH v2] misc: mic: Use memdup_user() as a cleanup

Hi,
Thanks.
Should I prepare fix patch only for missed label?

Regards Vasyl.

On Tue, Dec 12, 2017 at 12:49 PM, Greg KH <greg@...ah.com> wrote:
> On Tue, Dec 12, 2017 at 11:40:58AM +0100, Vasyl Gomonovych wrote:
>> Fix coccicheck warning which recommends to use memdup_user():
>>
>> drivers/misc/mic/vop/vop_vringh.c:940:14-21: WARNING opportunity for memdup_user
>> drivers/misc/mic/vop/vop_vringh.c:998:8-15: WARNING opportunity for memdup_user
>>
>> Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci
>>
>> Changelog:
>>  - v1:
>>    - Replace kzalloc + copy_from_user on memdup_user
>>  - v2:
>>    - Clear forgotten done label
>>      After merging the char-misc tree, today's linux-next build
>>      (x86_64_allmodconfig) produced this warning:
>>      drivers/misc/mic/vop/vop_vringh.c: In function 'vop_ioctl':
>>      drivers/misc/mic/vop/vop_vringh.c:1001:1: warning: label 'done' defined but not used [-Wunused-label]
>
> Will not work as I already have taken v1.
>
> Also, put the changelog below the --- line please.
>
> thanks,
>
> greg k-h



-- 
Доброї вам пори дня.