[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 12 Dec 2017 08:34:45 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: baijiaju1990@...il.com
Cc: mlindner@...vell.com, stephen@...workplumber.org,
shemminger@...l.org, shemminger@...ux-foundation.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove
From: Jia-Ju Bai <baijiaju1990@...il.com>
Date: Tue, 12 Dec 2017 16:38:12 +0800
> According to drivers/net/ethernet/marvell/skge.c, the driver may sleep
> under a spinlock.
> The function call path is:
> skge_remove (acquire the spinlock)
> free_irq --> may sleep
>
> I do not find a good way to fix it, so I only report.
> This possible bug is found by my static analysis tool (DSAC) and
> checked by my code review.
This was added by:
commit a9e9fd7182332d0cf5f3e601df3e71dd431b70d7
Author: Stephen Hemminger <shemminger@...tta.com>
Date: Tue Sep 27 13:41:37 2011 -0400
skge: handle irq better on single port card
I think the free_irq() can be moved below the unlock.
Stephen, please take a look.
Thanks!
Powered by blists - more mailing lists