linux-kernel - [BUG] drivers/scsi/ipr: two possible sleep-in-atomic bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 11:00:39 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     brking@...ibm.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-scsi@...r.kernel.org
Subject: [BUG] drivers/scsi/ipr: two possible sleep-in-atomic bugs

According to drivers/scsi/ipr.c, the kernel module may sleep under a 
spinlock.
The function call paths are:
ipr_shutdown (acquire the spinlock)
   irq_poll_disable
     msleep --> may sleep

ipr_ata_post_internal (acquire the spinlock)
   ipr_device_reset
     ipr_send_blocking_cmd
       wait_for_completion --> may sleep (&hrrq->_lock is still held)

I do not find a good way to fix them, so I only report.
These possible bugs are found by my static analysis tool (DSAC) and 
checked by my code review.


Thanks,
Jia-Ju Bai