lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171212150117.GM3958@kernel.org> Date: Tue, 12 Dec 2017 12:01:17 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Masami Hiramatsu <mhiramat@...nel.org> Cc: bhargavb <bhargavaramudu@...il.com>, linux-kernel@...r.kernel.org, Paul Clarke <pc@...ibm.com>, Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>, Thomas Richter <tmricht@...ux.vnet.ibm.com>, linux-rt-users@...r.kernel.org, linux-perf-users@...r.kernel.org Subject: Re: [PATCH v3 5/5] perf-probe: Support escaped character in parser Em Tue, Dec 12, 2017 at 11:46:00PM +0900, Masami Hiramatsu escreveu: > On Mon, 11 Dec 2017 17:03:30 -0300 > Arnaldo Carvalho de Melo <acme@...nel.org> wrote: > > > - /* We don't care about default symbol or not */ > > > - ver = strchr(norm, '@'); > > > - if (ver) { > > > - buf = strndup(norm, ver - norm); > > > - if (!buf) > > > - return -ENOMEM; > > > - norm = buf; > > > + if (cut_version) { > > > + /* We don't care about default symbol or not */ > > > + ver = strchr(norm, '@'); > > > + if (ver) { > > > + buf = strndup(norm, ver - norm); > > > + if (!buf) > > > + return -ENOMEM; > > > + norm = buf; > > You forgot a } here, please check this logic and resubmit just this last > > patch, without the string.c and string2.h part, that I already split > > from this one and applied. > OOPS! thanks! I missed something around that.... maybe while updating patches. > Hmm, I might be so upset... > OK, anyway, I'll do that. Nah, happens sometimes, one last round of building before submitting would catch that tho... 8-) :-) - Arnaldo
Powered by blists - more mailing lists