linux-kernel - Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 16:23:59 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Markus Heiser <markus.heiser@...marit.de>
Cc:     Michal Wajdeczko <michal.wajdeczko@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        joonas.lahtinen@...ux.intel.com,
        Chris Wilson <chris@...is-wilson.co.uk>,
        sagar.a.kamble@...el.com, jani.nikula@...ux.intel.com,
        rodrigo.vivi@...el.com, airlied@...ux.ie, daniel.vetter@...el.com,
        seanpaul@...omium.org, Jonathan Corbet <corbet@....net>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to
 intel_guc_fw.c

On Tue, Dec 12, 2017 at 01:11:43PM +0100, Markus Heiser wrote:
> 
> > Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko <michal.wajdeczko@...el.com>:
> > 
> > On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser <markus.heiser@...marit.de> wrote:
> > 
> >> With commit d9e2e0143c the 'GuC-specific firmware loader' doc
> >> section was removed from intel_guc_loader.c without a
> >> replacement.  So lets remove it from the Kernel-doc::
> >> 
> >>  .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
> >>     :doc: GuC-specific firmware loader
> >> 
> >> With commit e8668bbcb0 intel_guc_loader.c was renamed to to
> >> intel_guc_fw.c and to name just one, intel_guc_init_hw() was
> >> renamed to intel_guc_fw_upload(). Since we get errors in the
> >> Sphinx build like:
> >> 
> >> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
> >> 
> >> Change the kernel-doc directive from intel_guc_loader.c to
> >> intel_guc_fw.c
> >> 
> >> Signed-off-by: Markus Heiser <markus.heiser@...marit.de>
> >> ---
> > 
> > Thanks for your patch, but similar fix is already merged here [1]
> > 
> > Michal
> > 
> > [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
> 
> 
> Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader"
> fix in that patch (doc section was removed in d9e2e0143c).  Can you or
> someone else from @intel fix this also?

I've rebased the patch from you to only take that remaining part.

Thanks for fixing this.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch