linux-kernel - Re: [PATCH] spi: s3c64xx: add SPDX identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171212130313.GC1072@brancaleone.zhora.eu>
Date:   Tue, 12 Dec 2017 22:03:13 +0900
From:   Andi Shyti <andi@...zian.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Andi Shyti <andi.shyti@...sung.com>, Kukjin Kim <kgene@...nel.org>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier

Hi Krzysztof,

> > - * Copyright (C) 2009 Samsung Electronics Ltd.
> > - *     Jaswinder Singh <jassi.brar@...sung.com>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License as published by
> > - * the Free Software Foundation; either version 2 of the License, or
> > - * (at your option) any later version.
> > - *
> > - * This program is distributed in the hope that it will be useful,
> > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > - * GNU General Public License for more details.
> > - */
> > +// SPDX-License-Identifier: GPL-2.0
> 

> Existing license corresponds to GPL-2.0+, not GPL-2.0.

mmmhhh... isn't it deprecated from 2.0rc2? Current SPDX version
2.6 doesn't have GPL-2.0+ in the list of licenses.

https://spdx.org/licenses/

I can improve the commit log to state it more clearly. Would that
work?

BTW, is it really a change of license?

> Why changing the comment style?

That's SPDX, right? by adding the SPDX-License-Identifier the
GPLv2 statement becomes redundant and we can remove some lines.

Andi