linux-kernel - Re: [PATCH] platform/x86: Add driver for GPD pocket custom fan controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uE540=Y=pgz=tcM2djQVYZw5b8uOP5wQwJNNhCNEXuW=g@mail.gmail.com>
Date:   Tue, 12 Dec 2017 16:33:12 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, James <james@...aceas.org>
Subject: Re: [PATCH] platform/x86: Add driver for GPD pocket custom fan controller

Dear Hans,

On Tue, Dec 12, 2017 at 4:11 PM, Hans de Goede <hdegoede@...hat.com> wrote:
> Add a driver for the GPD pocket device's custom fan controller, which
> gets controlled through 2 GPIOs listed in a FAN02501 ACPI device.
[...]

> --- /dev/null
> +++ b/drivers/platform/x86/gpd-pocket-fan.c
> @@ -0,0 +1,193 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

This should be IMHO this style as requested by Linus on list and
documented by Thomas in the doc patches:
// SPDX-License-Identifier: GPL-2.0


> +MODULE_LICENSE("GPL");

This module license means "GPL 2 or later" and does not match your top
level GPL 2.0 license tag and should be instead as per module.h doc:
MODULE_LICENSE("GPL v2");

.... unless you want this to be GPL 2.0 or later all the way in which
case it should be:
// SPDX-License-Identifier: GPL-2.0+
and
MODULE_LICENSE("GPL");

... though I am not sure what is the point of "or later" for a module.

-- 
Cordially
Philippe Ombredanne