lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20171212.105350.1862932376620064454.davem@davemloft.net> Date: Tue, 12 Dec 2017 10:53:50 -0500 (EST) From: David Miller <davem@...emloft.net> To: makita.toshiaki@....ntt.co.jp Cc: eric@...it.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, ast@...nel.org, daniel@...earbox.net Subject: Re: [PATCH net-next] libbpf: add function to setup XDP From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> Date: Mon, 11 Dec 2017 11:24:12 +0900 > On 2017/12/09 23:43, Eric Leblond wrote: >> Most of the code is taken from set_link_xdp_fd() in bpf_load.c and >> slightly modified to be library compliant. >> >> Signed-off-by: Eric Leblond <eric@...it.org> > ... >> +int bpf_set_link_xdp_fd(int ifindex, int fd, __u32 flags) > ... >> + for (nh = (struct nlmsghdr *)buf; NLMSG_OK(nh, len); >> + nh = NLMSG_NEXT(nh, len)) { >> + if (nh->nlmsg_pid != getpid()) { > > Generally nlmsg_pid should not be compared with process id. > See man netlink and > https://github.com/iovisor/bcc/pull/1275/commits/69ce96a54c55960c8de3392061254c97b6306a6d Right. I wish we had never named this "pid", it gets misinterpreted way too easily.
Powered by blists - more mailing lists