linux-kernel - Re: [PATCH] Revert "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4afeb2a-1578-4c85-9ae4-20b028fd382e@gmail.com>
Date:   Tue, 12 Dec 2017 16:58:47 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        linux-mtd@...ts.infradead.org
Cc:     computersforpeace@...il.com, dwmw2@...radead.org,
        boris.brezillon@...e-electrons.com, richard@....at,
        linux-kernel@...r.kernel.org, Zhiqiang.Hou@....com,
        shawnguo@...nel.org, robh@...nel.org
Subject: Re: [PATCH] Revert "dt-bindings: mtd: add sst25wf040b and en25s64 to
 sip-nor list"

On 12/12/2017 02:40 PM, Cyrille Pitchen wrote:
> This reverts commit b07815d4eaf658b683c345d6e643895a20d92f29.
> 
> The reverted commit was merged into v4-15-rc1 by mistake: it was taken
> from the IMX tree but the patch has never been sent to linux-mtd nor
> reviewed by any spi-nor maintainers.
> 
> Actually, it would have been rejected since we add new values for the
> 'compatible' DT property only for SPI NOR memories that don't support
> the JEDEC READ ID op code (0x9F).
> 
> Both en25s64 and sst25wf040b support the JEDEC READ ID op code, hence
> should use the "jedec,spi-nor" string alone as 'compatible' value.
> 
> See the following link for more details:
> http://lists.infradead.org/pipermail/linux-mtd/2017-November/077425.html
> 
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>

Acked-by: Marek Vasut <marek.vasut@...il.com>

> ---
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> index 376fa2f50e6b..956bb046e599 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> @@ -13,7 +13,6 @@ Required properties:
>                   at25df321a
>                   at25df641
>                   at26df081a
> -                 en25s64
>                   mr25h128
>                   mr25h256
>                   mr25h10
> @@ -33,7 +32,6 @@ Required properties:
>                   s25fl008k
>                   s25fl064k
>                   sst25vf040b
> -                 sst25wf040b
>                   m25p40
>                   m25p80
>                   m25p16
> 


-- 
Best regards,
Marek Vasut